lianetm commented on code in PR #20521:
URL: https://github.com/apache/kafka/pull/20521#discussion_r2414431575
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##########
@@ -1203,12 +1202,21 @@ private void testConsumingWithNullGroupId(Map<String,
Object> consumerConfig) th
consumer3.assign(List.of(TP));
consumer3.seek(TP, 1);
- var numRecords1 = consumer1.poll(Duration.ofMillis(5000)).count();
+ TestUtils.waitForCondition(
+ () -> consumer1.poll(Duration.ofMillis(5000)).count() == 3,
+ "consumer1 did not consume from earliest offset"
+ );
Review Comment:
This doesn't seem needed either (none of the changes in this test). Trunk
version passes locally for me, so let's revert this (and take it as good news
again)
(basically whenever we have a single poll but with decent `pollTimeout`, no
callbacks getting in the way, I would expect that everything works the same
after this PR). It's poll(0) the one where I expect we might have slightly diff
behaviour for the async consumer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
