kevin-wu24 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r2433222429
##########
metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java:
##########
@@ -437,14 +438,40 @@ void doFormat(BootstrapMetadata bootstrapMetadata) throws
Exception {
directoryTypes.get(writeLogDir).description(), writeLogDir,
MetadataVersion.FEATURE_NAME, releaseVersion);
Files.createDirectories(Paths.get(writeLogDir));
- BootstrapDirectory bootstrapDirectory = new
BootstrapDirectory(writeLogDir);
+ File parentDir = new File(writeLogDir);
+ File clusterMetadataDirectory = new File(parentDir,
String.format("%s-%d",
+ CLUSTER_METADATA_TOPIC_PARTITION.topic(),
+ CLUSTER_METADATA_TOPIC_PARTITION.partition()));
+ Files.createDirectories(clusterMetadataDirectory.toPath());
+ BootstrapDirectory bootstrapDirectory = new
BootstrapDirectory(clusterMetadataDirectory.getPath());
bootstrapDirectory.writeBinaryFile(bootstrapMetadata);
if
(directoryTypes.get(writeLogDir).isDynamicMetadataDirectory()) {
- writeDynamicQuorumSnapshot(writeLogDir,
+
writeDynamicQuorumSnapshot(clusterMetadataDirectory.getPath(),
Review Comment:
We should rename `writeDynamicQuorumSnapshot` to `writeZeroSnapshot`, and
write it when formatting metadata directories. The semantics that change here
are that we should not write the KRaft control records (KRaft version and voter
set) when `!isDynamicMetadataDirectory()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
