m1a2st commented on code in PR #19527:
URL: https://github.com/apache/kafka/pull/19527#discussion_r2444900392
##########
clients/src/main/java/org/apache/kafka/common/security/auth/Login.java:
##########
@@ -25,6 +25,37 @@
/**
* Login interface for authentication.
+ * <p>
+ * Implements {@link org.apache.kafka.common.metrics.Monitorable} to allow the
callback to register metrics.
+ * Metrics are registered with different tags depending on the component type
and connection mode:
+ * </p>
+ * <ul>
+ * <li>Server component, ConnectionMode = Server
Review Comment:
> Maybe using brokers/controllers would be more explicit rather than Server
component, what do you think?
Thanks for the suggestion, I think the brokers/controllers are more explicit
for Kafka.
> Also I don't find ConnectionMode = Server/Client very clear. Maybe we
cab=n explicitly say what it is, for example (just giving you an idea, rephrase
accordingly) "receiving connections" or "connecting to the controller"?
The `ConnectionMode` (server/client) indicates which side accepts
connections and which side initiates them. I have updated the comment to make
this explanation more explicit.”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
