JimmyWang6 commented on code in PR #20246:
URL: https://github.com/apache/kafka/pull/20246#discussion_r2449119652
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1709,6 +1780,10 @@ private int acquireSubsetBatchRecords(
.setLastOffset(offsetState.getKey())
.setDeliveryCount((short)
offsetState.getValue().deliveryCount()));
acquiredCount++;
+ if (isRecordLimitMode && acquiredCount >= maxFetchRecords) {
Review Comment:
@adixitconfluent Thanks for your comments! You are right, and I was just
trying to be more defensive here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
