lucliu1108 commented on code in PR #20693:
URL: https://github.com/apache/kafka/pull/20693#discussion_r2449380906
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java:
##########
@@ -255,24 +257,32 @@ record = queue.poll(wallClockTime);
if (record != null) {
Review Comment:
Record should not be `null`. If it is null then the queue itself is also
empty (which is detected in the outer loop).
I tried to add a else statement that throws an exception, and is detected by
`SpotBugs` as "redundant null check". Therefore i think it's fine to drop it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
