DL1231 commented on code in PR #20614:
URL: https://github.com/apache/kafka/pull/20614#discussion_r2454768605
##########
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##########
@@ -342,9 +344,14 @@ private static boolean retainsBufferReference(Schema
schema) {
Schema.Visitor detector = new Schema.Visitor() {
@Override
public void visit(Type field) {
- if (field == BYTES || field == NULLABLE_BYTES || field ==
RECORDS ||
- field == COMPACT_BYTES || field == COMPACT_NULLABLE_BYTES)
+ // avoid BooleanExpressionComplexity checkstyle warning
Review Comment:
I tried that, but the build failed.
https://github.com/apache/kafka/actions/runs/18641614486/job/53141605094
<pre>Caused by: java.lang.NullPointerException: Cannot invoke
"java.util.Set.contains(Object)" because
"org.apache.kafka.common.protocol.ApiKeys.BUFFER_FIELDS" is null
> Task :core:genProtocolApiKeyDocs FAILED
at
org.apache.kafka.common.protocol.ApiKeys$1.visit(ApiKeys.java:354)</pre>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
