mingyen066 commented on code in PR #20741: URL: https://github.com/apache/kafka/pull/20741#discussion_r2459427832
########## gradle/wrapper/README.md: ########## @@ -0,0 +1,40 @@ +# Gradle Wrapper + +This directory contains the Gradle wrapper files for the Apache Kafka project. + +## Upgrading Gradle version + +When upgrading the Gradle version used by the Kafka project, update the following files in order: + +1. **Update Gradle version** in `gradle/dependencies.gradle`: + ```groovy + gradle: "9.2.0" + ``` + +2. **Update distribution checksums** in `gradle/wrapper/gradle-wrapper.properties`: + - Find the SHA256 checksum for the binary distribution at https://gradle.org/release-checksums/ + - Update `distributionSha256Sum` with the Binary-only (-bin) ZIP Checksum + - Update `distributionUrl` to point to the new version: Review Comment: ```suggestion - Update `distributionUrl` to use the latest version from `https://services.gradle.org/distributions/`: ``` ########## gradle/wrapper/README.md: ########## @@ -0,0 +1,40 @@ +# Gradle Wrapper + +This directory contains the Gradle wrapper files for the Apache Kafka project. + +## Upgrading Gradle version + +When upgrading the Gradle version used by the Kafka project, update the following files in order: + +1. **Update Gradle version** in `gradle/dependencies.gradle`: + ```groovy + gradle: "9.2.0" + ``` + +2. **Update distribution checksums** in `gradle/wrapper/gradle-wrapper.properties`: + - Find the SHA256 checksum for the binary distribution at https://gradle.org/release-checksums/ + - Update `distributionSha256Sum` with the Binary-only (-bin) ZIP Checksum + - Update `distributionUrl` to point to the new version: + ```properties + distributionSha256Sum=<sha256-checksum-from-release-page> + distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.0-bin.zip + ``` + - Verify the distribution URL is accessible Review Comment: I’m not sure why this verification is needed. The link distribution URL in `https://services.gradle.org/distributions/` will be accessible. ########## gradle/wrapper/README.md: ########## @@ -0,0 +1,40 @@ +# Gradle Wrapper + +This directory contains the Gradle wrapper files for the Apache Kafka project. + +## Upgrading Gradle version + +When upgrading the Gradle version used by the Kafka project, update the following files in order: + +1. **Update Gradle version** in `gradle/dependencies.gradle`: + ```groovy + gradle: "9.2.0" + ``` + +2. **Update distribution checksums** in `gradle/wrapper/gradle-wrapper.properties`: + - Find the SHA256 checksum for the binary distribution at https://gradle.org/release-checksums/ + - Update `distributionSha256Sum` with the Binary-only (-bin) ZIP Checksum + - Update `distributionUrl` to point to the new version: + ```properties + distributionSha256Sum=<sha256-checksum-from-release-page> + distributionUrl=https\://services.gradle.org/distributions/gradle-9.2.0-bin.zip + ``` + - Verify the distribution URL is accessible + +3. **Update wrapper JAR checksum** in `wrapper.gradle`: + - Find the Wrapper JAR Checksum at https://gradle.org/release-checksums/ + - Update the `wrapperChecksum` variable (line 42): Review Comment: I think we shouldn't hardcode the line number here. how about: ```suggestion - Update the `wrapperChecksum` variable: ```groovy task bootstrapWrapper() { ... doLast { ... String wrapperChecksum = "<wrapper-jar-sha256-checksum>" ``` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
