lucasbru commented on code in PR #20764:
URL: https://github.com/apache/kafka/pull/20764#discussion_r2460316576
##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommandOptions.java:
##########
@@ -144,11 +140,10 @@ public StreamsGroupCommandOptions(String[] args) {
deleteOpt = parser.accepts("delete", DELETE_DOC);
deleteOffsetsOpt = parser.accepts("delete-offsets",
DELETE_OFFSETS_DOC);
timeoutMsOpt = parser.accepts("timeout", TIMEOUT_MS_DOC)
- .availableIf(describeOpt)
Review Comment:
This timeout is anyways used in list groups, it seems.
##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommandOptions.java:
##########
@@ -214,9 +209,6 @@ void checkArgs() {
if (options.has(describeOpt)) {
checkDescribeArgs();
- } else {
- if (options.has(timeoutMsOpt))
- LOGGER.debug("Option " + timeoutMsOpt + " is applicable only
when " + describeOpt + " is used.");
Review Comment:
not true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
