TaiJuWu commented on code in PR #20770:
URL: https://github.com/apache/kafka/pull/20770#discussion_r2463237015
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -372,13 +318,8 @@ public class ConsumerConfig extends AbstractConfig {
/**
* <code>share.acknowledgement.mode</code>
*/
- public static final String SHARE_ACKNOWLEDGEMENT_MODE_CONFIG =
"share.acknowledgement.mode";
- private static final String SHARE_ACKNOWLEDGEMENT_MODE_DOC = "Controls the
acknowledgement mode for a share consumer." +
- " If set to <code>implicit</code>, the acknowledgement mode of the
consumer is implicit and it must not" +
- " use
<code>org.apache.kafka.clients.consumer.ShareConsumer.acknowledge()</code> to
acknowledge delivery of records. Instead," +
- " delivery is acknowledged implicitly on the next call to poll or
commit." +
- " If set to <code>explicit</code>, the acknowledgement mode of the
consumer is explicit and it must use" +
- "
<code>org.apache.kafka.clients.consumer.ShareConsumer.acknowledge()</code> to
acknowledge delivery of records.";
+ public static final String SHARE_ACKNOWLEDGEMENT_MODE_CONFIG =
CommonConsumerConfigs.SHARE_ACKNOWLEDGEMENT_MODE_CONFIG;
Review Comment:
Not sure we should remove this due to the config is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
