jiafu1115 commented on code in PR #20691:
URL: https://github.com/apache/kafka/pull/20691#discussion_r2464445009
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ShareGroupCommandTest.java:
##########
@@ -245,7 +245,7 @@ public void testDescribeOffsetsOfExistingGroupWithNulls()
throws Exception {
DescribeShareGroupsResult describeShareGroupsResult =
mock(DescribeShareGroupsResult.class);
ShareGroupDescription exp = new ShareGroupDescription(
firstGroup,
- List.of(new ShareMemberDescription("memid1", "clId1", "host1",
new ShareMemberAssignment(
+ List.of(new ShareMemberDescription("memid1",
Optional.of("rackId1"), "clId1", "host1", new ShareMemberAssignment(
Review Comment:
done
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -4758,6 +4758,7 @@ public void testDescribeOldAndNewConsumerGroups() throws
Exception {
new MemberDescription(
"memberId",
Optional.of("instanceId"),
+ Optional.of("rackid"),
Review Comment:
done.thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
