adixitconfluent commented on code in PR #20765:
URL: https://github.com/apache/kafka/pull/20765#discussion_r2464831012
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -212,32 +210,30 @@ public void
testTryCompleteWhenMinBytesNotSatisfiedOnFirstFetch() {
when(sp0.canAcquireRecords()).thenReturn(true);
when(sp1.canAcquireRecords()).thenReturn(false);
- when(sp0.acquire(any(), anyInt(), anyInt(), anyLong(), any(),
any())).thenReturn(
- createShareAcquiredRecords(new
ShareFetchResponseData.AcquiredRecords().setFirstOffset(0).setLastOffset(3).setDeliveryCount((short)
1)));
// We are testing the case when the share partition is getting fetched
for the first time, so for the first time
- // the fetchOffsetMetadata will return empty. Post the readFromLog
call, the fetchOffsetMetadata will be
+ // the fetchOffsetMetadata will return empty. Post the
isMinBytesSatisfied call, the fetchOffsetMetadata will be
Review Comment:
Why does this comment need a change? I think the comment that makes more
sense is `Post the first readFromLog call...`
##########
core/src/test/java/kafka/server/share/DelayedShareFetchTest.java:
##########
@@ -212,32 +210,30 @@ public void
testTryCompleteWhenMinBytesNotSatisfiedOnFirstFetch() {
when(sp0.canAcquireRecords()).thenReturn(true);
when(sp1.canAcquireRecords()).thenReturn(false);
- when(sp0.acquire(any(), anyInt(), anyInt(), anyLong(), any(),
any())).thenReturn(
- createShareAcquiredRecords(new
ShareFetchResponseData.AcquiredRecords().setFirstOffset(0).setLastOffset(3).setDeliveryCount((short)
1)));
// We are testing the case when the share partition is getting fetched
for the first time, so for the first time
- // the fetchOffsetMetadata will return empty. Post the readFromLog
call, the fetchOffsetMetadata will be
+ // the fetchOffsetMetadata will return empty. Post the
isMinBytesSatisfied call, the fetchOffsetMetadata will be
Review Comment:
I think the comment that makes more sense is `Post the first readFromLog
call...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
