smjn commented on code in PR #20732:
URL: https://github.com/apache/kafka/pull/20732#discussion_r2465468378
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchRequest.java:
##########
@@ -137,6 +138,12 @@ public ShareFetchRequestData data() {
@Override
public ShareFetchRequest build(short version) {
+ if (version < 2) {
+ // The v1 does not support ShareAcquireMode Renew.
Review Comment:
This comment needs to be revised? We are checking renewal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
