chia7712 commented on code in PR #20674:
URL: https://github.com/apache/kafka/pull/20674#discussion_r2483868212
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -4518,8 +4518,10 @@ private static byte[] getSaltedPassword(ScramMechanism
publicScramMechanism, byt
public DescribeFeaturesResult describeFeatures(final
DescribeFeaturesOptions options) {
final KafkaFutureImpl<FeatureMetadata> future = new
KafkaFutureImpl<>();
final long now = time.milliseconds();
+ final NodeProvider nodeProvider = options.nodeId().isPresent() ?
+ new ConstantNodeIdProvider(options.nodeId().getAsInt(),
metadataManager.usingBootstrapControllers()) : new
LeastLoadedBrokerOrActiveKController();
Review Comment:
I don't see why we need to use `metadataManager.usingBootstrapControllers()`
instead of `true`. This request should be fully supported with the bootstrap
controller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
