mjsax commented on code in PR #20767:
URL: https://github.com/apache/kafka/pull/20767#discussion_r2496586923
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -349,23 +345,26 @@ private void handleTaskCorruptedException(final
TaskCorruptedException taskCorru
// TODO: we can let the exception encode the actual corrupted
changelog partitions and only
// mark those instead of marking all changelogs
private void removeCheckpointForCorruptedTask(final Task task) {
- task.markChangelogAsCorrupted(task.changelogPartitions());
+ try {
+ task.markChangelogAsCorrupted(task.changelogPartitions());
- // we need to enforce a checkpoint that removes the corrupted
partitions
- measureCheckpointLatency(() -> task.maybeCheckpoint(true));
+ // we need to enforce a checkpoint that removes the corrupted
partitions
+ measureCheckpointLatency(() -> task.maybeCheckpoint(true));
+ } catch (final StreamsException e) {
+ log.warn("Checkpoint failed for corrupted task {}", task.id(),
e);
+ }
}
private void handleStreamsException(final StreamsException
streamsException) {
log.info("Encountered streams exception: ", streamsException);
if (streamsException.taskId().isPresent()) {
- handleStreamsExceptionWithTask(streamsException);
+ handleStreamsExceptionWithTask(streamsException,
streamsException.taskId().get());
} else {
handleStreamsExceptionWithoutTask(streamsException);
}
}
- private void handleStreamsExceptionWithTask(final StreamsException
streamsException) {
- final TaskId failedTaskId = streamsException.taskId().get();
+ private void handleStreamsExceptionWithTask(final StreamsException
streamsException, final TaskId failedTaskId) {
Review Comment:
Why do we need this change? Seem the overall idea is to add `TaskId` to
`StreamsException` if we have a `TaskId` at hand when we create the
`StreamsException`. Why do we need a second way to get the `TaskId` ?
Or to rephrase: why can't we update the code which throws a
`StreamsException` to include the `TaskId` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
