iit2009060 commented on code in PR #20723:
URL: https://github.com/apache/kafka/pull/20723#discussion_r2496651292
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1759,6 +1760,7 @@ public Map<String, Object> getMainConsumerConfigs(final
String groupId, final St
// Get main consumer override configs
final Map<String, Object> mainConsumerProps =
originalsWithPrefix(MAIN_CONSUMER_PREFIX);
+ checkIfUnexpectedUserSpecifiedConsumerConfig(mainConsumerProps,
NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS);
Review Comment:
@mjsax The check inside getCommonConsumerConfigs() is not enough because
it only validates the base consumer.* prefix, not the specialized prefixes like
main.consumer.*.
This check validates for main.consumer prefix config like
main.consumer.allow.auto.create.topics
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1867,6 +1867,7 @@ public Map<String, Object> getGlobalConsumerConfigs(final
String clientId) {
// Get global consumer override configs
final Map<String, Object> globalConsumerProps =
originalsWithPrefix(GLOBAL_CONSUMER_PREFIX);
+ checkIfUnexpectedUserSpecifiedConsumerConfig(globalConsumerProps,
NON_CONFIGURABLE_CONSUMER_DEFAULT_CONFIGS);
Review Comment:
@mjsax The check inside getCommonConsumerConfigs() is not enough because
it only validates the base consumer.* prefix, not the specialized prefixes like
main.consumer.*.
This check validates for main.consumer prefix config like
main.consumer.allow.auto.create.topics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
