AndrewJSchofield commented on code in PR #20857: URL: https://github.com/apache/kafka/pull/20857#discussion_r2511600687
########## clients/src/main/resources/common/message/WriteTxnMarkersRequest.json: ########## @@ -21,7 +21,8 @@ // Version 0 was removed in Apache Kafka 4.0, Version 1 is the new baseline. // // Version 1 enables flexible versions. - "validVersions": "1", + // Version 2 adds TransactionVersion field to WritableTxnMarker. + "validVersions": "1-2", Review Comment: I think you need to bump the version of response too, even though the schema itself is not changing. ########## clients/src/main/resources/common/message/WriteTxnMarkersRequest.json: ########## @@ -21,7 +21,8 @@ // Version 0 was removed in Apache Kafka 4.0, Version 1 is the new baseline. // // Version 1 enables flexible versions. - "validVersions": "1", + // Version 2 adds TransactionVersion field to WritableTxnMarker. Review Comment: If you could put the KIP number in the comment, it would help future maintainers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
