ShivsundarR commented on code in PR #20838:
URL: https://github.com/apache/kafka/pull/20838#discussion_r2513795040
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##########
@@ -632,7 +644,7 @@ private ShareFetch<K, V> pollForFetches(final Timer timer) {
// If data is available already, return it immediately
final ShareFetch<K, V> fetch = collect(acknowledgementsMap);
- if (!fetch.isEmpty()) {
+ if (!fetch.isEmpty() && !fetch.hasRenewals()) {
Review Comment:
I did not understand the need for the additional check here, I will read
through again, the check outside this in `poll()` does not have this additional
check (in line 612), so was wondering.
When we do have `inFlightRecords` to return, we should return them to the
application right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
