chickenchickenlove opened a new pull request, #20863: URL: https://github.com/apache/kafka/pull/20863
### Description - Related Issue - https://issues.apache.org/jira/browse/KAFKA-19393 Currently, Both `SubscriptionState` and `AbstractMembershipManager` have states related with Assignment as their member fields. So, it can be confusing point because which one is source of truth. Therefore, It would be better to consolidate consumer assignment state views. ### Discussion Points. In this PR, `AbstractMembershipManager` has still `currentAssignments` and `currentTargetAssignments`. The `LocalAssignment` includes information of assignment and information of protocol between consumer - broker. So, I'm not sure that `AssignState` or `SubscriptionState` knows information of protocol between consumer - broker. So, apart from that, I’ve extracted all the remaining assignment-related data into `AssignState`. In addition to, IMHO, Also, since `AssignState` is a subdomain of `Subscription` in terms of meaning, it has been extracted as an internal state within `Subscription`. I made a commit based on my thoughts! It would like to hear feedback from others. Please take a look, @lianetm and other reviewer 🙇♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
