eduwercamacaro commented on code in PR #20403:
URL: https://github.com/apache/kafka/pull/20403#discussion_r2518592424
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -493,7 +493,6 @@ private void setupTask(final StreamsConfig streamsConfig,
streamsMetrics,
cache
);
- context.setRecordContext(new ProcessorRecordContext(0L, -1L, -1,
null, new RecordHeaders()));
Review Comment:
It turns out that some tests failed because of this change, and I missed
them because I forgot to run the tests in the test-utils project.
The RecordContext should be set by Kafka Streams itself, so I still don't
think this is a good place to put it. But if we remove this, the
`TopologyTestDriver` class won't be able to return writable state stores;
that's the reason why the tests were failing only in the test-utils project.
I added this
[commit](https://github.com/apache/kafka/pull/20403/commits/9a6c582fdca37ae3855c0ed2b1b71fc92c0fcf51)
that sets the record context when clients try to get a state store from the
`TopologyTestDriver` class.
All the test passes now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
