jolshan commented on code in PR #20868:
URL: https://github.com/apache/kafka/pull/20868#discussion_r2520452354
##########
core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala:
##########
@@ -369,10 +382,23 @@ class TransactionMarkerChannelManagerTest {
assertEquals(1,
channelManager.queueForUnknownBroker.totalNumMarkers(txnTopicPartition2))
val expectedBroker1Request = new WriteTxnMarkersRequest.Builder(
- util.List.of(new WriteTxnMarkersRequest.TxnMarkerEntry(producerId1,
producerEpoch, coordinatorEpoch, txnResult, util.List.of(partition1)),
- new WriteTxnMarkersRequest.TxnMarkerEntry(producerId2, producerEpoch,
coordinatorEpoch, txnResult, util.List.of(partition1)))).build()
+ util.List.of(
+ new WriteTxnMarkersRequest.TxnMarkerEntry(producerId1, producerEpoch,
coordinatorEpoch, txnResult, util.List.of(partition1)),
+ new WriteTxnMarkersRequest.TxnMarkerEntry(producerId2, producerEpoch,
coordinatorEpoch, txnResult, util.List.of(partition1))
+ ),
+ util.List.of(
+ TransactionVersion.TV_2.featureLevel().toByte,
Review Comment:
Should we have any tests with two different versions? Maybe not in this file
necessarily, but made me think of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
