m1a2st commented on code in PR #20844:
URL: https://github.com/apache/kafka/pull/20844#discussion_r2541584883
##########
clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java:
##########
@@ -169,14 +169,14 @@ public class BrokerSecurityConfigs {
.define(SslConfigs.SSL_TRUSTMANAGER_ALGORITHM_CONFIG, STRING,
SslConfigs.DEFAULT_SSL_TRUSTMANAGER_ALGORITHM, MEDIUM,
SslConfigs.SSL_TRUSTMANAGER_ALGORITHM_DOC)
.define(SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_CONFIG,
STRING, SslConfigs.DEFAULT_SSL_ENDPOINT_IDENTIFICATION_ALGORITHM, LOW,
SslConfigs.SSL_ENDPOINT_IDENTIFICATION_ALGORITHM_DOC)
.define(SslConfigs.SSL_SECURE_RANDOM_IMPLEMENTATION_CONFIG,
STRING, null, LOW, SslConfigs.SSL_SECURE_RANDOM_IMPLEMENTATION_DOC)
- .define(SslConfigs.SSL_CIPHER_SUITES_CONFIG, LIST,
Collections.emptyList(), MEDIUM, SslConfigs.SSL_CIPHER_SUITES_DOC)
+ .define(SslConfigs.SSL_CIPHER_SUITES_CONFIG, LIST, List.of(),
ConfigDef.ValidList.anyNonDuplicateValues(true, false), MEDIUM,
SslConfigs.SSL_CIPHER_SUITES_DOC)
.define(SslConfigs.SSL_ENGINE_FACTORY_CLASS_CONFIG, CLASS, null,
LOW, SslConfigs.SSL_ENGINE_FACTORY_CLASS_DOC)
// Sasl Configuration
.define(BrokerSecurityConfigs.SASL_MECHANISM_INTER_BROKER_PROTOCOL_CONFIG,
STRING, SaslConfigs.DEFAULT_SASL_MECHANISM, MEDIUM,
BrokerSecurityConfigs.SASL_MECHANISM_INTER_BROKER_PROTOCOL_DOC)
- .define(BrokerSecurityConfigs.SASL_ENABLED_MECHANISMS_CONFIG,
LIST, BrokerSecurityConfigs.DEFAULT_SASL_ENABLED_MECHANISMS, MEDIUM,
BrokerSecurityConfigs.SASL_ENABLED_MECHANISMS_DOC)
+ .define(BrokerSecurityConfigs.SASL_ENABLED_MECHANISMS_CONFIG,
LIST, BrokerSecurityConfigs.DEFAULT_SASL_ENABLED_MECHANISMS,
ConfigDef.ValidList.anyNonDuplicateValues(false, false), MEDIUM,
BrokerSecurityConfigs.SASL_ENABLED_MECHANISMS_DOC)
Review Comment:
Thanks for the reminder, I have updated this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
