chia7712 commented on code in PR #20792:
URL: https://github.com/apache/kafka/pull/20792#discussion_r2543321764
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventHandler.java:
##########
@@ -69,7 +70,8 @@ public ApplicationEventHandler(final LogContext logContext,
networkClientDelegateSupplier,
requestManagersSupplier,
asyncConsumerMetrics);
- this.networkThread.start();
+
+ this.networkThread.start(initializationTimeoutMs);
Review Comment:
Should we shut down the networkThread after it throws an exception? If we
don't, we might have a leak since the thread will still be running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
