DL1231 commented on PR #20837: URL: https://github.com/apache/kafka/pull/20837#issuecomment-3562128960
@apoorvmittal10 Thanks very much for your detailed and patient review. I have updated the PR—please take another look when you have time. I agree that it makes sense to apply throttling when the delivery count limit is set to 2. In fact, I initially implemented it that way. However, I noticed that many of the existing UTs and ITs related to the `DeliveryCountLimit` started failing, and the required changes were quite extensive. Therefore, I think it might be more appropriate to address this in a follow-up PR, allowing the current PR to focus specifically on the core throttling logic. What do you think? If you don’t have the bandwidth later, I’m happy to take over the follow-up task. But if you’re interested, please feel free to go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
