jack2012aa commented on code in PR #20791:
URL: https://github.com/apache/kafka/pull/20791#discussion_r2553355471
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##########
@@ -337,7 +337,8 @@ void runOnce() {
long currentTimeMs = time.milliseconds();
long pollTimeout = sendProducerData(currentTimeMs);
- client.poll(pollTimeout, currentTimeMs);
+ if (!forceClose)
Review Comment:
Yes. The overhead is too large to eliminate it.
Instead of solving the condition, the new version of code tries to fix the
flaky assertion, as discussed personally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
