AndrewJSchofield commented on code in PR #20991:
URL: https://github.com/apache/kafka/pull/20991#discussion_r2560643606
##########
docs/ops.html:
##########
@@ -243,6 +243,9 @@ <h4 class="anchor-heading"><a id="basic_ops_share_group"
class="anchor-link"></a
GROUP TOPIC PARTITION START-OFFSET LAG
my-share-group topic1 0 4 0</code></pre>
+ The start-offset represents the offset available for shared consumers.
However, records already past the start-offset
Review Comment:
I suggest `The start offset is the earliest offset for in-flight records
being evaluated for delivery to share consumers. Some records after the start
offset may already have completed delivery.`
##########
tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommandOptions.java:
##########
@@ -39,7 +39,9 @@ public class ShareGroupCommandOptions extends
CommandDefaultOptions {
"When resetting offsets, partitions can be specified using this
format: 'topic1:0,1,2', where 0,1,2 are the partitions to be included.";
private static final String ALL_TOPICS_DOC = "Consider all topics assigned
to a share group in the 'reset-offsets' process.";
private static final String LIST_DOC = "List all share groups.";
- private static final String DESCRIBE_DOC = "Describe share group, members
and offset information.";
+ private static final String DESCRIBE_DOC = "Describe share group, members
and start-offset information. Note: The start-offset represents "
Review Comment:
I think I'd just revert this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
