smjn commented on code in PR #21001:
URL: https://github.com/apache/kafka/pull/21001#discussion_r2567700111
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/NetworkPartitionMetadataClient.java:
##########
@@ -231,11 +265,13 @@ private boolean
maybeHandleErrorResponse(Map<TopicPartition, CompletableFuture<O
log.error("Version mismatch exception",
clientResponse.versionMismatch());
error = Errors.UNKNOWN_SERVER_ERROR;
} else if (clientResponse.wasDisconnected()) {
- log.error("Response for ListOffsets for TopicPartitions: {} was
disconnected - {}.", partitionFutures.keySet(), clientResponse);
+ log.warn("Response for ListOffsets for TopicPartitions: {} was
disconnected - {}.", partitionFutures.keySet(), clientResponse);
error = Errors.NETWORK_EXCEPTION;
+ shouldRetry = true;
} else if (clientResponse.wasTimedOut()) {
- log.error("Response for ListOffsets for TopicPartitions: {} timed
out - {}.", partitionFutures.keySet(), clientResponse);
+ log.warn("Response for ListOffsets for TopicPartitions: {} timed
out - {}.", partitionFutures.keySet(), clientResponse);
Review Comment:
remove logging from retriable requests - log if attempts exhausted only.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/NetworkPartitionMetadataClient.java:
##########
@@ -231,11 +265,13 @@ private boolean
maybeHandleErrorResponse(Map<TopicPartition, CompletableFuture<O
log.error("Version mismatch exception",
clientResponse.versionMismatch());
error = Errors.UNKNOWN_SERVER_ERROR;
} else if (clientResponse.wasDisconnected()) {
- log.error("Response for ListOffsets for TopicPartitions: {} was
disconnected - {}.", partitionFutures.keySet(), clientResponse);
+ log.warn("Response for ListOffsets for TopicPartitions: {} was
disconnected - {}.", partitionFutures.keySet(), clientResponse);
error = Errors.NETWORK_EXCEPTION;
+ shouldRetry = true;
} else if (clientResponse.wasTimedOut()) {
- log.error("Response for ListOffsets for TopicPartitions: {} timed
out - {}.", partitionFutures.keySet(), clientResponse);
+ log.warn("Response for ListOffsets for TopicPartitions: {} timed
out - {}.", partitionFutures.keySet(), clientResponse);
Review Comment:
maybe remove logging from retriable requests - log if attempts exhausted
only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
