DL1231 commented on code in PR #20614: URL: https://github.com/apache/kafka/pull/20614#discussion_r2570670616
########## clients/src/main/java/org/apache/kafka/common/protocol/types/NullableSchema.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.common.protocol.types; + +import java.nio.ByteBuffer; +import java.util.Arrays; + +/** + * The nullable schema for a compound record definition + */ +public final class NullableSchema extends Schema { + + private static final String NULLABLE_STRUCT_TYPE_NAME = "NULLABLE_STRUCT"; + + public NullableSchema(Schema schema) { + super(schema.tolerateMissingFieldsWithDefaults(), Arrays.stream(schema.fields()).map(field -> field.def).toArray(Field[]::new)); + } + + @Override + public boolean isNullable() { + return true; + } + + /** + * Write a struct to the buffer with special handling for null values + * If the input object is null, writes a byte value of -1 to the buffer as a null indicator. + */ + @Override + public void write(ByteBuffer buffer, Object o) { + if (o == null) { + buffer.put((byte) -1); + return; + } + + buffer.put((byte) 1); + super.write(buffer, o); + } + + @Override + public Struct read(ByteBuffer buffer) { + byte nullIndicator = buffer.get(); + if (nullIndicator < 0) + return null; + + return super.read(buffer); + } + + @Override + public int sizeOf(Object o) { + if (o == null) + return 1; + + return 1 + super.sizeOf(o); + } + + @Override + public Struct validate(Object item) { + if (item == null) + return null; + + return super.validate(item); + } + + @Override + public String typeName() { + return NULLABLE_STRUCT_TYPE_NAME; + } + + @Override + public String leftBracket() { + return "?{"; Review Comment: Thanks for the review, I have updated the PR. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
