TaiJuWu commented on PR #20859:
URL: https://github.com/apache/kafka/pull/20859#issuecomment-3594464927

   > Kevin and I had an offline discussion about this, we agree:
   > 
   > 1. Go with server-side `ReplicaKey` idempotency approach. Even if the 
`UpdateVoterSetTimer` is not required in the client side, and the `LEO==0` 
check should work, but the client-side gating is still as not reliable as in 
the server-side.
   > 2. We can get the implementation ready first (without test), and waiting 
for other reviewers' comments, especially the KIP-853 author @jsancio 's 
comments.
   > 3. After everyone is onboard with this solution, we add tests and review 
and merge it in v4.2.0.
   > 
   > @TaiJuWu , let us know if you have any other thoughts. Thank you.
   
   I also agree your approach, that is really better than current design, will 
close this PR, thanks for your participation! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to