chia7712 commented on code in PR #21008:
URL: https://github.com/apache/kafka/pull/21008#discussion_r2576416756
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -2535,12 +2535,12 @@ public void scheduleUnloadOperation(
/**
* A new metadata image is available.
*
- * @param newImage The new metadata image.
- * @param delta The metadata delta.
+ * @param delta The metadata delta.
+ * @param newImage The new metadata image.
*/
- public void onNewMetadataImage(
- CoordinatorMetadataImage newImage,
- CoordinatorMetadataDelta delta
+ public void onMetadataUpdate(
+ CoordinatorMetadataDelta delta,
Review Comment:
> if people agree with the general approach
If the interfaces `CoordinatorMetadataImage` and `CoordinatorMetadataDelta`
are not referenced by `ShareCoordinator` or `GroupCoordinator`, can we remove
them by using record class to rewrite them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
