kirktrue opened a new pull request, #21038: URL: https://github.com/apache/kafka/pull/21038
The intention of the `Consumer` API is that after `close()`, `metrics()` should return an empty map of metrics. The lifecycle management of the various metrics managers in the consumer is inconsistent. Some managers remove all the metrics that were created, some registries remove some of them, and some don't make any effort to remove the metrics at all. This change introduces `AbstractConsumerMetricsManager` as a shared base class for consumer metrics managers, consolidating the steps of metric registration and cleanup logic, as well as unit tests to ensure that the different metrics managers perform the cleanup step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
