chia7712 commented on code in PR #21029:
URL: https://github.com/apache/kafka/pull/21029#discussion_r2580464643
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##########
@@ -1098,10 +1100,13 @@ public void onTopicsDeleted(Set<Uuid> deletedTopicIds,
BufferSupplier bufferSupp
}
@Override
- public void onNewMetadataImage(CoordinatorMetadataImage newImage,
FeaturesImage newFeaturesImage, CoordinatorMetadataDelta delta) {
+ public void onMetadataUpdate(MetadataDelta delta, MetadataImage newImage) {
throwIfNotActive();
- this.runtime.onMetadataUpdate(delta, newImage);
- boolean enabled = isShareGroupsEnabled(newFeaturesImage);
+ this.runtime.onMetadataUpdate(
+ new KRaftCoordinatorMetadataDelta(Objects.requireNonNull(delta,
"delta must be provided")),
Review Comment:
some methods of `KRaftCoordinatorMetadataDelta` assume `metadataDelta` can
be null, but other methods, such as `hashCode` and `equals`, don't handle
`null` value. I guess you will have a follow-up patch to refactor all the
null-handling logic at once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
