chia7712 commented on code in PR #21026:
URL: https://github.com/apache/kafka/pull/21026#discussion_r2580620128
##########
build.gradle:
##########
@@ -129,6 +132,14 @@ allprojects {
mavenCentral()
}
+ plugins.withType(JavaPlugin).configureEach {
Review Comment:
Please merge this to existent `java` block. For example:
```
java {
toolchain {
languageVersion = JavaLanguageVersion.of(javaToolChainVersion)
}
// We should only set this if Java version is < 9 (--release is
recommended for >= 9), but the Scala plugin for IntelliJ sets
// `-target` incorrectly if this is unset
sourceCompatibility = minJavaVersion
targetCompatibility = minJavaVersion
}
```
##########
build.gradle:
##########
@@ -248,7 +259,7 @@ if (repo != null) {
} else {
rat.enabled = false
}
-println("Starting build with version $version (commit id ${commitId == null ?
"null" : commitId.take(8)}) using Gradle $gradleVersion, Java
${JavaVersion.current()} and Scala ${versions.scala}")
+println("Starting build with version $version (commit id ${commitId == null ?
"null" : commitId.take(8)}) using Gradle $gradleVersion, Java
${java.toolchain.languageVersion.get()} and Scala ${versions.scala}")
Review Comment:
Could you use `javaToolChainVersion` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
