dajac commented on code in PR #21047:
URL: https://github.com/apache/kafka/pull/21047#discussion_r2580925943
##########
core/src/test/scala/unit/kafka/server/GroupCoordinatorBaseRequestTest.scala:
##########
@@ -80,6 +80,22 @@ class GroupCoordinatorBaseRequestTest(cluster:
ClusterInstance) {
}
}
+ protected def createTopicWithAdminRaw(
Review Comment:
We already have `createTopic` in this class. I wonder whether we could unify
both. Have you checked by chance?
##########
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala:
##########
@@ -80,150 +80,145 @@ class ConsumerGroupDescribeRequestTest(cluster:
ClusterInstance) extends GroupCo
createOffsetsTopic()
val admin = cluster.admin()
Review Comment:
Do we still need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]