AndrewJSchofield commented on code in PR #21045:
URL: https://github.com/apache/kafka/pull/21045#discussion_r2581133593
##########
server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java:
##########
@@ -107,12 +107,14 @@ public synchronized int size() {
}
/**
- * Remove all the share sessions from cache.
+ * Remove all the share sessions from cache. The method do not notify the
share group listener
Review Comment:
nit: "The method does not"
##########
server/src/main/java/org/apache/kafka/server/share/session/ShareSession.java:
##########
@@ -85,6 +93,10 @@ public synchronized Boolean isEmpty() {
return partitionMap.isEmpty();
}
+ public synchronized String connectionId() {
Review Comment:
As a final field, surely connectionId is not going to change and there's no
need to synchronize. I do understand how the class in general needs to consider
thread-safety.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
