AndrewJSchofield commented on code in PR #21051:
URL: https://github.com/apache/kafka/pull/21051#discussion_r2582065371
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -10635,6 +10738,113 @@ public void
testAcquireMultipleRecordsWithOverlapAndNewBatchInRecordLimitMode()
assertEquals(5,
sharePartitionMetrics.inFlightBatchMessageCount().max());
}
+ /**
+ * Test validates the scenario where the partition has been re-initialized
with a moved start offset.
+ * In this case, the acquire logic should respect the new start offset and
not allow acquiring
+ * records post the new start offset. For the test, simulate a scenario
where the log batch is 0-99
Review Comment:
nit: I think "records before the new start offset" is what it means. The fix
makes sure the earliest acquisition offset is never before the start offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
