squah-confluent commented on PR #20847:
URL: https://github.com/apache/kafka/pull/20847#issuecomment-3606087799
Thanks for updating the PR. I think the metrics approach looks good now.
I'm not really happy with the naming in the public interfaces. If it's not
too late to update the KIP, I would propose the following:
* Rename the config to "group.coordinator.append.max.cached.buffer.size" and
"share.coordinator.append.max.cached.buffer.size".
* Add "cached" because we can temporarily allocate a larger buffer when
building the batch.
* Rename "coordinator-append-buffer-size-bytes" to
"batch-buffer-cache-size-bytes".
* Remove "coordinator" from the name because the full name is
"kafka.server:type=group-coordinator-metrics,
name=coordinator-append-buffer-size-bytes" and it's redundant to have it twice.
* Prefix with "batch" because it's related to "batch-linger-ms" and
"batch-flush-ms".
* Add "cache".
* Rename "coordinator-append-buffer-skip-cache-count" to
"batch-buffer-cache-discard-count".
* "Discard" to align with the method name in `CoordinatorRuntimeMetrics`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
