dajac commented on code in PR #21052:
URL: https://github.com/apache/kafka/pull/21052#discussion_r2584640057
##########
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/KRaftCoordinatorMetadataDeltaTest.java:
##########
@@ -32,20 +32,14 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class KRaftCoordinatorMetadataDeltaTest {
@Test
public void testKRaftCoordinatorDeltaWithNulls() {
- assertTrue(new
KRaftCoordinatorMetadataDelta(null).changedTopicIds().isEmpty());
- assertTrue(new KRaftCoordinatorMetadataDelta(new
MetadataDelta(MetadataImage.EMPTY)).changedTopicIds().isEmpty());
Review Comment:
All the tests taking `null` are irrelevant now and I found the others weird
as they are not really related to testing the `null` case too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
