lucasbru commented on code in PR #21011:
URL: https://github.com/apache/kafka/pull/21011#discussion_r2584997380
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2064,9 +2063,9 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
TasksTuple targetAssignment;
if (groupEpoch > group.assignmentEpoch()) {
boolean initialDelayActive =
timer.isScheduled(streamsInitialRebalanceKey(groupId));
- if (initialDelayActive && group.assignmentEpoch() == 0) {
+ if (initialDelayActive) {
// During initial rebalance delay, return empty assignment to
first joining members.
Review Comment:
Got your point. You're not wrong. But I think in the classic protocol, we
also used the "initial rebalance" term for every rebalance that happens due to
a first member joining an empty group. So maybe it's fine?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
