jsancio commented on code in PR #21025:
URL: https://github.com/apache/kafka/pull/21025#discussion_r2582183275
##########
raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java:
##########
@@ -156,6 +156,23 @@ public CompletableFuture<AddRaftVoterResponseData>
handleAddVoterRequest(
);
}
+
+ if (!ackWhenCommitted && partitionState.hasSeenReplicaKey(voterKey)) {
+ // ackWhenCommitted is used to distinguish the request from admin
+ // or broker. If it comes from broker and had been in cluster, we
should
+ // reject it.
Review Comment:
This is a peculiar association. Why should "ack when committed" requests
fail if the voter key is in the log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
