rionmonster opened a new pull request, #21072:
URL: https://github.com/apache/kafka/pull/21072

   ### Description
   
   Closes: [KAFKA-19941](https://issues.apache.org/jira/browse/KAFKA-19941)
   
   The goal of this minor pull request was to improve the existing readability 
for the `kafka-features.sh` output which could be difficult to decipher due to 
the inadequate spacing between properties. This change improves that spacing by 
introducing a second tab between each of the available properties (e.g. `\t` -> 
`'\t\t`).
   
   In addition to these changes all of the affected tests within the 
`FeatureCommandTest` suite were updated to ensure all of the existing tests 
were passing after the changes were made.
   
   ### Discussion and Rationale
   
   These changes were discussed briefly within [this mailing list 
thread](https://lists.apache.org/thread/jwcn88o4f4c19x1onymxmkddk3dcsckf), 
however the conversation was primarily about if adjusting output would equate 
to changing a public interface -- thus requiring a KIP.
   
   While there were several possible options to improve the readability or to 
support multiple formats potentially via an output parameter (e.g. 
`--output=table` to table-formatted output, similarly with JSON, etc.), these 
would be much larger bodies of work. The simplest approach in this case was to 
just improve the spacing and allow the end-user to adopt their preferred 
transformation from the existing format.
   
   ### Example Output
   
   <img width="1172" height="157" alt="additional-tabbed-kafka-feature-output" 
src="https://github.com/user-attachments/assets/20ca3ad7-7077-4a01-b700-3f5bcebe836e";
 />
   
   ### Mentions
   
   Tagging @chia7712 for review (as the initial creator of the JIRA)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to