bbejeck commented on code in PR #21091:
URL: https://github.com/apache/kafka/pull/21091#discussion_r2593449572
##########
streams/src/main/java/org/apache/kafka/streams/internals/metrics/OpenIterators.java:
##########
@@ -29,45 +25,26 @@
import java.util.concurrent.atomic.AtomicLong;
public class OpenIterators {
- private final TaskId taskId;
- private final String metricsScope;
- private final String name;
- private final StreamsMetricsImpl streamsMetrics;
private final NavigableSet<MeteredIterator> openIterators = new
ConcurrentSkipListSet<>(Comparator.comparingLong(MeteredIterator::startTimestamp));
private final AtomicLong oldestStartTimestamp = new AtomicLong();
- private MetricName metricName;
-
- public OpenIterators(final TaskId taskId,
- final String metricsScope,
- final String name,
- final StreamsMetricsImpl streamsMetrics) {
- this.taskId = taskId;
- this.metricsScope = metricsScope;
- this.name = name;
- this.streamsMetrics = streamsMetrics;
- }
+ public OpenIterators() { }
Review Comment:
> So wondering, if we should remove OpenIterator class entirely and go back
to the old code, but instead of returning null, return 0L:
I was thinking the same, but I liked the testability of the stand-alone
class, but I'm not sure it justifies the extra class
I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
