squah-confluent commented on PR #21073: URL: https://github.com/apache/kafka/pull/21073#issuecomment-3619726611
The test failures were my fault. They're fixed now. Really nice improvement! I notice we are missing test coverage for the comparator. The change looks correct but it would be nice to test we aren't changing behavior in any edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
