kevin-wu24 commented on code in PR #21053:
URL: https://github.com/apache/kafka/pull/21053#discussion_r2604188961
##########
metadata/src/main/java/org/apache/kafka/image/ConfigurationDelta.java:
##########
@@ -57,7 +59,17 @@ public void deleteAll() {
public ConfigurationImage apply() {
Map<String, String> newData = new HashMap<>(image.data().size());
+ Type resourceType = image.resource().type();
+ Set<String> validConfigNames = resourceType != Type.UNKNOWN ?
+ ConfigurationsDelta.getValidConfigNames(resourceType) : Set.of();
Review Comment:
Look at `ConfigCommandOptions#addConfig` for the whitelist we should be
using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
