chia7712 commented on code in PR #20847:
URL: https://github.com/apache/kafka/pull/20847#discussion_r2605016022
##########
coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java:
##########
@@ -772,13 +780,20 @@ private void freeCurrentBatch() {
// Cancel the linger timeout.
currentBatch.lingerTimeoutTask.ifPresent(TimerTask::cancel);
- // Release the buffer only if it is not larger than the
maxBatchSize.
- int maxBatchSize = partitionWriter.config(tp).maxMessageSize();
+ // Release the buffer only if it is not larger than the
cachedBufferMaxBytes.
+ int cachedBufferMaxBytes = cachedBufferMaxBytesSupplier.get();
- if (currentBatch.builder.buffer().capacity() <= maxBatchSize) {
+ if (currentBatch.builder.buffer().capacity() <=
cachedBufferMaxBytes) {
bufferSupplier.release(currentBatch.builder.buffer());
- } else if (currentBatch.buffer.capacity() <= maxBatchSize) {
+ cachedBufferSize.set(currentBatch.builder.buffer().capacity());
+ } else if (currentBatch.buffer.capacity() <= cachedBufferMaxBytes)
{
bufferSupplier.release(currentBatch.buffer);
+ cachedBufferSize.set(currentBatch.buffer.capacity());
+ // If the builder expands the buffer beyond the
cachedBufferMaxBytes, that should also increment the discard counter.
Review Comment:
`increment` -> `increase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
