chia7712 commented on code in PR #21101:
URL: https://github.com/apache/kafka/pull/21101#discussion_r2605100310
##########
core/src/test/scala/unit/kafka/server/AbstractMetadataRequestTest.scala:
##########
@@ -23,13 +23,27 @@ import kafka.utils.TestUtils
import org.apache.kafka.common.message.MetadataRequestData
import org.apache.kafka.common.protocol.Errors
import org.apache.kafka.common.requests.{MetadataRequest, MetadataResponse}
+import org.apache.kafka.common.test.ClusterInstance
import org.apache.kafka.coordinator.group.GroupCoordinatorConfig
-import org.apache.kafka.server.config.{ServerConfigs, ReplicationConfigs}
+import org.apache.kafka.server.IntegrationTestUtils
+import org.apache.kafka.server.config.{ReplicationConfigs, ServerConfigs}
import org.junit.jupiter.api.Assertions.assertEquals
-abstract class AbstractMetadataRequestTest extends BaseRequestTest {
+import java.util
+import scala.jdk.CollectionConverters.{CollectionHasAsScala, MapHasAsJava,
SeqHasAsJava}
- override def brokerPropertyOverrides(properties: Properties): Unit = {
+abstract class AbstractMetadataRequestTest(cluster: ClusterInstance) {
Review Comment:
Since `AbstractMetadataRequestTest` is only used by `MetadataRequestTest`.
Perhaps we could merge the two files together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
