Copilot commented on code in PR #21130:
URL: https://github.com/apache/kafka/pull/21130#discussion_r2610918968
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-max</td>
+ <td>The maximum time in ms taken for tasks-assigned rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-lost-latency-avg</td>
+ <td>The average time in ms taken for tasks-lost rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-lost-latency-max</td>
+ <td>The maximum time in ms taken for tasks-lost rebalance listener
callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be
consistent with other thread-level latency metrics in this section (e.g.,
commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a
comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The maximum execution time in ms, taken for tasks-lost rebalance
listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener
callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be
consistent with other thread-level latency metrics in this section (e.g.,
commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a
comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The average execution time in ms, taken for tasks-revoked
rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener
callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be
consistent with other thread-level latency metrics in this section (e.g.,
commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a
comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The average execution time in ms, taken for tasks-assigned
rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-max</td>
+ <td>The maximum time in ms taken for tasks-assigned rebalance listener
callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be
consistent with other thread-level latency metrics in this section (e.g.,
commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a
comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The maximum execution time in ms, taken for tasks-assigned
rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-max</td>
+ <td>The maximum time in ms taken for tasks-assigned rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-lost-latency-avg</td>
+ <td>The average time in ms taken for tasks-lost rebalance listener
callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be
consistent with other thread-level latency metrics in this section (e.g.,
commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a
comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The average execution time in ms, taken for tasks-lost rebalance
listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener
callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener
callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be
consistent with other thread-level latency metrics in this section (e.g.,
commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a
comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The maximum execution time in ms, taken for tasks-revoked
rebalance listener callback.</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
