chia7712 commented on code in PR #21027:
URL: https://github.com/apache/kafka/pull/21027#discussion_r2616063796
##########
server-common/src/main/java/org/apache/kafka/server/share/persister/PersisterStateManager.java:
##########
@@ -211,13 +210,10 @@ public PersisterStateManagerHandler(
this.onCompleteCallback = response -> {
}; // noop
partitionKey = SharePartitionKey.getInstance(groupId, topicId,
partition);
- String canonicalName = getClass().getCanonicalName();
- if (canonicalName == null) {
- canonicalName = getClass().getName();
- }
- log = LoggerFactory.getLogger(canonicalName);
}
+ protected abstract Logger log();
Review Comment:
Could you add comments for this abstract method? otherwise, it looks like
the method is implemented by a java tourist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
