chia7712 commented on code in PR #21135:
URL: https://github.com/apache/kafka/pull/21135#discussion_r2617362658
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java:
##########
@@ -142,7 +140,30 @@ public void onTimeout() {
});
}
- protected void
handleAllocateProducerIdsResponse(AllocateProducerIdsResponse response) {
+ protected void handleUnsuccessfulResponse() {
Review Comment:
nit: private should suffice
##########
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/RPCProducerIdManager.java:
##########
@@ -51,7 +51,7 @@ public class RPCProducerIdManager implements
ProducerIdManager {
private final String logPrefix;
private final int brokerId;
- private final Time time;
+ protected final Time time;
Review Comment:
nit: package-private is sufficient here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
