eduwercamacaro commented on code in PR #20749:
URL: https://github.com/apache/kafka/pull/20749#discussion_r2621100614
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -205,7 +212,8 @@ public ProcessorStateManager(final TaskId taskId,
final ChangelogRegister changelogReader,
final Map<String, String>
storeToChangelogTopic,
final Collection<TopicPartition>
sourcePartitions,
- final boolean stateUpdaterEnabled) throws
ProcessorStateException {
+ final boolean stateUpdaterEnabled,
+ final boolean startupState) throws
ProcessorStateException {
Review Comment:
Mostly, this boolean flag controls when to call the `preInit` and the `init`
methods within this class. This is because the `ProcessorStateManager` is the
one that controls the state store lifecycle.
But I think it is probably better to create a new method that specifically
registers startup states. I made some changes that removes this field by adding
a new method in the ProcessorStateManager. see [this
commit](https://github.com/apache/kafka/pull/20749/commits/fd93623864f3ae78edab8ac876ded56a495b21ac)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
