kamalcph commented on code in PR #21102:
URL: https://github.com/apache/kafka/pull/21102#discussion_r2623330454
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -379,7 +385,13 @@ public static ConfigDef configDef() {
DEFAULT_REMOTE_LIST_OFFSETS_REQUEST_TIMEOUT_MS,
atLeast(1),
MEDIUM,
- REMOTE_LIST_OFFSETS_REQUEST_TIMEOUT_MS_DOC);
+ REMOTE_LIST_OFFSETS_REQUEST_TIMEOUT_MS_DOC)
+ .define(REMOTE_LOG_DIRECT_BUFFER_POOL_ENABLED_PROP,
Review Comment:
could you mark the config as internal until the KIP gets approved?
`.define` -> `.defineInternal`
##########
clients/src/main/java/org/apache/kafka/common/record/RemoteLogInputStream.java:
##########
@@ -17,24 +17,36 @@
package org.apache.kafka.common.record;
import org.apache.kafka.common.errors.CorruptRecordException;
+import org.apache.kafka.common.utils.DirectBufferPool;
import org.apache.kafka.common.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.Closeable;
import java.io.IOException;
import java.io.InputStream;
import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.List;
import static org.apache.kafka.common.record.Records.HEADER_SIZE_UP_TO_MAGIC;
import static org.apache.kafka.common.record.Records.LOG_OVERHEAD;
import static org.apache.kafka.common.record.Records.MAGIC_OFFSET;
import static org.apache.kafka.common.record.Records.SIZE_OFFSET;
-public class RemoteLogInputStream implements LogInputStream<RecordBatch> {
+public class RemoteLogInputStream implements LogInputStream<RecordBatch>,
Closeable {
+ private static final Logger log =
LoggerFactory.getLogger(RemoteLogInputStream.class);
Review Comment:
logger is unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
